This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: remove format and/or codec options#69
Merged
achingbrain merged 1 commit intomasterfrom Jan 9, 2020
Merged
Conversation
IPFS is all `dag-pb` yet we allow passing `dag-cbor` as the format of IPLD node to use. This is likely to break anything that uses it as tools expect IPFS stuff to be `dag-pb`, possibly with `raw` leaves. Closes #67 BREAKING CHANGE: `--format` and/or `--codec` option has been removed from the CLI, the HTTP API and the core API.
achingbrain
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Jan 11, 2020
BREAKING CHANGE: `format` option is no longer supported as everything is `dag-pb` all of the time. Follows on from ipfs-inactive/js-ipfs-mfs#69
alanshaw
pushed a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Jan 12, 2020
BREAKING CHANGE: `format` option is no longer supported as everything is `dag-pb` all of the time. Follows on from ipfs-inactive/js-ipfs-mfs#69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPFS is all
dag-pbyet we allow passingdag-cboras the format of IPLD node to use. This is likely to break anything that uses it as tools expect IPFS stuff to bedag-pb, possibly withrawleaves.Closes #67
BREAKING CHANGE:
formatand/orcodecoption has been removed from the CLI, the HTTP API and the core API.